Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with sprockets #169

Open
jhovad opened this issue Oct 7, 2024 · 1 comment
Open

Compatibility with sprockets #169

jhovad opened this issue Oct 7, 2024 · 1 comment

Comments

@jhovad
Copy link

jhovad commented Oct 7, 2024 •
edited
Loading

Hi! I noticed that PR#87 introduced a dependency on propshaft.

Was this change intentional, and is it necessary?

It seems that this update has made the gem incompatible with projects that are still using sprockets.

We’d really love to continue using this gem with sprockets if possible. Thank you!
@ryantaylor
Copy link

This is the commit that added the dependency: d8bee68, looks like it was made back in July on a PR that was first opened in February: #87

Seems the incompatibility was unexpected, I agree that it would be nice to be able to continue using this tool with sprockets (I am also not able to use the latest version because of this).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jhovad @ryantaylor