Remove multi_json as dependency in favor of std-lib json #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherguy
force-pushed
the
remove-multi-json
branch
from
b375f17
to
a1a8f88
Compare
byroot
reviewed
Sep 4, 2024
|
Looks fine, but lots of issues with CI. Let's get the MultiJson removal and CI fixes in different PRs. |
|
I merged the dependency removal. However I tried to really update the CI matrix but it's a huge pain -_-. |
|
The failure on edge is also on 7.2. I dug a bit as to what is going on, but I'm a bit tired. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is almost identical to #212 but for security reasons we want to maintain our own fork.
CI is also updated to include newer Ruby and Rails versions (currently failing on
edgebut that is expected).