Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ui needs a way to tell when a dao has multiple minions. #72

Open
dekanbro opened this issue Jul 15, 2020 · 2 comments
Open

Ui needs a way to tell when a dao has multiple minions. #72

dekanbro opened this issue Jul 15, 2020 · 2 comments

Comments

@dekanbro
Copy link
Contributor

The list of proposals from a dao is filtered on the proposal details field and if isMinion exists. There also needs to be a way to tell which minion in the case where a DAO has multiple minions.

@dekanbro
Copy link
Contributor Author

this is probably related to #34

@tarunbhm
Copy link

In minion submitted proposal we have minion address as applicant so when we get list of proposals and see details field isMinion == true we can check for applicant address and based on that figure out which minion sent it. We can also use proposer field in proposal struct to check for it in case later on we want to specify applicant as actually user who created minion action from UI.

But that raises another question. Is there any specific reason behind keeping minion as applicant in proposals? it can cause issues later on when we want to automate grants proposal through a minion. If we keep minion as applicant then minion also needs to implement token transfer logic (pull pattern).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants