-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement client facing theme #95
Comments
Any styles that are currently handled in the component could ideally be moved to the theme. Streamlining to one set of components unless there is additional complexity there.
Could be a separate storybook. Whatever solution seems easiest to maintain. |
@scottrepreneur ended up implementing it as a theme switch. Going through the components to determine where styling still has to be moved into the theme, doesn't seem to be much. Some open questions
Also, the |
Starting work on implementing the client facing theme. Some questions, which we may have partially answered already but good to leave a written down version so it's available to everybody.
Card.tsx
. In our previous call, I think we decided to duplicate components as well as providing a raidguild/client theme. The downside of this approach is that developers will be required to import the correct components from eg@raidguild/design-system/rg
and@raidguild/design-system/client
. The upside is that we don't have to rewrite anything that's already there.Pinging @scottrepreneur and @bitbeckers
The text was updated successfully, but these errors were encountered: