send, test/send: isolate cease_adv of add_ra_header #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin H. Johnson <[email protected]>
The add_ra_header function had a hidden dependency on system state: If cease_adv was not set, the outcome was dependent on the sysctl knob "net.ipv6.conf.all.forwarding". This was visible only during testing with net.ipv6.conf.all.forwarding=1. If tested with net.ipv6.conf.all.forwarding=0, the tests passed. Hoist the sysctl dependency out of the add_ra_header function, to enable testing of both code paths, and add the extra test to validate both states of the cease_adv input. Closes: radvd-project#200 Signed-off-by: Robin H. Johnson <[email protected]>
robbat2
force-pushed
the
fix-cease-adv-testcase
branch
from
c2dc8c9
to
9db91d5
Compare
mpontillo
reviewed
Jan 14, 2023
Signed-off-by: Robin H. Johnson <[email protected]>
The existing count-- placement inside the loop removed the commas after each byte. Keep the commas. Signed-off-by: Robin H. Johnson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The add_ra_header function had a hidden dependency on system state:
If cease_adv was not set, the outcome was dependent on the sysctl knob
"net.ipv6.conf.all.forwarding".
This was visible only during testing with
net.ipv6.conf.all.forwarding=1. If tested with
net.ipv6.conf.all.forwarding=0, the tests passed.
Hoist the sysctl dependency out of the add_ra_header function, to enable
testing of both code paths, and add the extra test to validate both
states of the cease_adv input.
Also improve
snprint_safe_buffer:{seen in this comment Build failure with test_add_ra_header on aarch64 #200 (comment))Closes: #200
Signed-off-by: Robin H. Johnson [email protected]