From 27ada9668270319b2795977d7086f22e16040a39 Mon Sep 17 00:00:00 2001 From: Gonzalo <456459+grzuy@users.noreply.github.com> Date: Wed, 15 Nov 2023 13:30:55 -0300 Subject: [PATCH] ci: no longer test against rack 1 (#627) --- .github/workflows/build.yml | 9 --------- Appraisals | 13 ------------- gemfiles/rack_1.gemfile | 15 --------------- 3 files changed, 37 deletions(-) delete mode 100644 gemfiles/rack_1.gemfile diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index c7950f0f..024bddd3 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -26,7 +26,6 @@ jobs: gemfile: - rack_3 - rack_2 - - rack_1 - rails_7_1 - rails_7_0 - rails_6_1 @@ -47,8 +46,6 @@ jobs: - active_support_5_redis_cache_store_pooled - redis_store exclude: - - gemfile: rack_1 - ruby: '3.2' - gemfile: rails_5_2 ruby: '3.2' - gemfile: active_support_5_redis_cache_store @@ -57,8 +54,6 @@ jobs: ruby: '3.2' - gemfile: dalli2 ruby: '3.2' - - gemfile: rack_1 - ruby: '3.1' - gemfile: rails_5_2 ruby: '3.1' - gemfile: active_support_5_redis_cache_store @@ -67,8 +62,6 @@ jobs: ruby: '3.1' - gemfile: dalli2 ruby: '3.1' - - gemfile: rack_1 - ruby: '3.0' - gemfile: rails_5_2 ruby: '3.0' - gemfile: active_support_5_redis_cache_store @@ -77,8 +70,6 @@ jobs: ruby: '3.0' - gemfile: dalli2 ruby: '3.0' - - gemfile: rack_1 - ruby: '2.7' - gemfile: rails_7_0 ruby: '2.6' - gemfile: rails_7_0 diff --git a/Appraisals b/Appraisals index f68e8b7f..6250f3aa 100644 --- a/Appraisals +++ b/Appraisals @@ -8,19 +8,6 @@ appraise "rack_2" do gem "rack", "~> 2.0" end -appraise "rack_1" do - # Override activesupport and actionpack version constraints by making - # it more loose so it's compatible with rack 1.6.x - gem "actionpack", ">= 4.2" - gem "activesupport", ">= 4.2" - - gem "rack", "~> 1.6" - - # Override rack-test version constraint by making it more loose - # so it's compatible with actionpack 4.2.x - gem "rack-test", ">= 0.6" -end - appraise 'rails_7-1' do gem 'railties', '~> 7.1.0' end diff --git a/gemfiles/rack_1.gemfile b/gemfiles/rack_1.gemfile deleted file mode 100644 index 36b2f91b..00000000 --- a/gemfiles/rack_1.gemfile +++ /dev/null @@ -1,15 +0,0 @@ -# This file was generated by Appraisal - -source "https://rubygems.org" - -gem "actionpack", ">= 4.2" -gem "activesupport", ">= 4.2" -gem "rack", "~> 1.6" -gem "rack-test", ">= 0.6" - -group :maintenance, optional: true do - gem "bake" - gem "bake-gem" -end - -gemspec path: "../"