-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Outline #3
Comments
Lately I've been thinking about adding one more chapter - "Extending tmap". It could explain users how to add new features to tmap or modify existing ones. Of course, explaining all of the tmap code complexity, etc. could be a very hard thing to do - so I totally would understand if that is out of the book scope. |
I totally agree with you that this chapter would be highly beneficial. Not just for the readers, but also for us. In the current state, tmap is not so generic that extensions are easy. Mainly, this has to do with the fact that aesthetics are pre-specified, e.g. tm_shape(x) +
tm_polygons("pop_dens", setup = aes_col(style = "quantile", palette = "Purples"))
tm_shape(y) +
tm_symbols(size = "count", size.setup = aes_size(sizes.legend = c(100, 200, 400), size.max = 1000)) Well, this should be an issue for For the moment, yes, a chapter "Extending tmap" would be great, but I have the feeling that we'll have to wait a bit for tmap 4.0. In the meantime we can continue with the other chapters. |
Dear Martijn and Jakub, I hope you don't mind my message but I was wondering if you could add a new chapter/section to the book where you explain how to work with legends since, IMO, that's the most frustrating aspect of tmap. |
@agila5 definitely! I looked at our (preliminary) outline, and I think we should add a legend section to the layout chapter. Do you have any specific questions/problems that we should cover there? |
I've updated the outline, see https://github.com/r-tmap/tmap-book/blob/master/meta/book-outline.Rmd
One difference with what we discussed yesterday, is that I've placed the chapter about other map types (cartogram, geogrid) as 6th. Why? Because it is a natural extension/use of the map layers, and belongs to the basic 'how to map data' part. So therefore also before layout and small multiples.
We can continue the discussion about the outline in this issue if needed.
The text was updated successfully, but these errors were encountered: