Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Palette suffixes to prefixes #398

Merged
merged 5 commits into from
Nov 6, 2023
Merged

Palette suffixes to prefixes #398

merged 5 commits into from
Nov 6, 2023

Conversation

teunbrand
Copy link
Contributor

This PR aims to fix #390 (comment).

Briefly, it renames all *_pal functions to pal_* functions, while keeping the suffixed versions as aliases.

@thomasp85
Copy link
Member

Can I get you to fix conflicts

Merge branch 'main' into pal_alias

# Conflicts:
#	R/pal-dichromat.R
#	R/pal-hue.R
#	R/pal-shape.r
#	man/pal_area.Rd
#	man/pal_brewer.Rd
#	man/pal_dichromat.Rd
#	man/pal_div_gradient.Rd
#	man/pal_gradient_n.Rd
#	man/pal_grey.Rd
#	man/pal_hue.Rd
#	man/pal_identity.Rd
#	man/pal_linetype.Rd
#	man/pal_manual.Rd
#	man/pal_rescale.Rd
#	man/pal_seq_gradient.Rd
#	man/pal_shape.Rd
#	man/pal_viridis.Rd
@teunbrand
Copy link
Contributor Author

Done. These conflicts after renaming files from .r to .R are my least favourite conflicts so far.

@thomasp85
Copy link
Member

I can imagine 😅

@thomasp85 thomasp85 merged commit 727bd71 into r-lib:main Nov 6, 2023
12 checks passed
@thomasp85
Copy link
Member

Thanks

@teunbrand teunbrand deleted the pal_alias branch November 6, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

*_trans suffixed functions would be easier to use if they were renamed to be trans_* prefixed functions
2 participants