Add figure space as style_positive option
#366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can I get you to update the PR to remove conflicts? |
bwiernik
force-pushed
the
figure-space
branch
from
76378e5
to
d0c9548
Compare
|
I rebased the PR and the conflicts are resolved now. |
|
The failing check appears to be unrelated to the PR (it's in |
|
Thanks - can I get you to add a news bullet |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a third option for
style_positive. Ifstyle_positive = "space", positive values are prepended by\u2007(see https://www.fileformat.info/info/unicode/char/2007/index.htm).\u2007is a "figure space" -- a blank space the same width as a digit or+or proper minus sign. Compared to usingstyle_positive = "none", prepending a figure space to positive numbers can help ensure that positive and negative numbers are consistently aligned, especially when they are left- or right-justified.