Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add styled sonner draft #666

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

ditadi
Copy link
Contributor

@ditadi ditadi commented Mar 25, 2024

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests
  • Other

Why is it needed?

Increase the variety of components on qwik-ui by adding a sonner component from qwik-sonner.

Gravacao.de.Tela.2024-03-25.as.17.44.55.mov

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have ran pnpm change and documented my changes
  • I have add necessary docs (if needed)
  • Added new tests to cover the fix / functionality

Copy link

changeset-bot bot commented Mar 25, 2024

⚠️ No Changeset found

Latest commit: f2d4d00

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@thejackshelton
Copy link
Collaborator

Looks good! @maiieul if you could double check since you work more on the styled kit, otherwise happy to merge.

@maiieul
Copy link
Contributor

maiieul commented Jul 9, 2024

Hmmm interesting I didn't comment in here..

We can't merge this as is cause the styled kit is expected to use headless components under the hood, and cva.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants