Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[📖]Clarify steps for changing the application's theme at the click of a button #925

Open
drk-mtr opened this issue Aug 12, 2024 · 1 comment
Labels
COMMUNITY: good first issue Good for newcomers COMMUNITY: PR is welcomed We think it's a good feature to have but would love for the community to help with the PR for it PKG: docs Improvements or additions to documentation PKG: styled kit Related to the styled kit

Comments

@drk-mtr
Copy link

drk-mtr commented Aug 12, 2024

Suggestion

On this page: https://qwikui.com/docs/styled/install/

It states: This might seem like a lot of configuration, but we believe it to be worth it because it allows changing your entire application's theme at the click of a button.

I'm not sure how this would be achieved. I'm not suggesting we necessarily need a comprehensive guide on this, however it might be worth stating the basic idea. I'm guessing this refers to configuring multiple tailwind themes as per this sort of process? https://dev.to/ultroneoustech/creating-multiple-themes-in-tailwind-css-and-nextjs-2e98

Thanks for the brilliant library btw, I love the philosophy behind it.

@drk-mtr drk-mtr added PKG: docs Improvements or additions to documentation STATUS-1: needs triage This doesn't seem right labels Aug 12, 2024
@maiieul
Copy link
Contributor

maiieul commented Aug 21, 2024

Ah sorry about the confusion here. What I meant by "at the click of a button", is the ability for the developer to simply click on the make it yours button, chose his preset, color and radios, then copy code then the entire theme is changed. no need to change CSS in your components. I didn't mean that for the end user, although it's definitely possible to provide that to the end user as that's what we do in Qwik UI for the developers (our end users 😓 ). Maybe Qwik UI could make implementing such a feature easier in the future, but that's not our current priority.

Would you be up to making a docs PR to rephrase this?

@maiieul maiieul added COMMUNITY: good first issue Good for newcomers COMMUNITY: PR is welcomed We think it's a good feature to have but would love for the community to help with the PR for it PKG: styled kit Related to the styled kit and removed STATUS-1: needs triage This doesn't seem right labels Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
COMMUNITY: good first issue Good for newcomers COMMUNITY: PR is welcomed We think it's a good feature to have but would love for the community to help with the PR for it PKG: docs Improvements or additions to documentation PKG: styled kit Related to the styled kit
Projects
Status: Backlog
Development

No branches or pull requests

2 participants