Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML Reporter: Check for undefined testItem in testDone callback #1562

Merged
merged 1 commit into from
Mar 13, 2021
Merged

HTML Reporter: Check for undefined testItem in testDone callback #1562

merged 1 commit into from
Mar 13, 2021

Conversation

Krinkle
Copy link
Member

@Krinkle Krinkle commented Mar 13, 2021

For added robustness, allow the DOM node to be missing at this point just in case.

Extracted from #1391.

@step2yeung @Krinkle
HTML Reporter: Check for undefined testItem in testDone callback
a5eeac1 
For added robustness, allow the DOM node to be missing at this point
just in case. Extracted from #1391.
@Krinkle Krinkle force-pushed the fix-runner branch 2 times, most recently from 900c66e to a5eeac1 Compare March 13, 2021 22:57
@Krinkle Krinkle merged commit 036ac23 into master Mar 13, 2021
@Krinkle Krinkle deleted the fix-runner branch March 13, 2021 23:00
@Krinkle Krinkle mentioned this pull request May 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Krinkle @step2yeung