Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack overflow on very long inputs #855

Open
markasoftware opened this issue Sep 21, 2022 · 0 comments
Open

Stack overflow on very long inputs #855

markasoftware opened this issue Sep 21, 2022 · 0 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers perf Performance (time or memory) related matters.

Comments

@markasoftware
Copy link
Contributor

This is clearly evident when running the QASM benchmark suite, specifically 9symml_195.qasm. The problem is in process-includes, which uses tail recursion to loop over all the instructions. One solution is to add a local declare form to process-includes increasing the speed optimization to ensure that it uses tail recursion by default (at least in SBCL). Another solution is to use a loop. And the final option is to do nothing at all and assume any circuit long enough to exhaust the stack is simply too long for Quilc (since it blows the heap on my machine during addressing on this 9symml_195.qasm anyway)

@stylewarning stylewarning added bug Something isn't working perf Performance (time or memory) related matters. good first issue Good for newcomers labels Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers perf Performance (time or memory) related matters.
Projects
None yet
Development

No branches or pull requests

3 participants