Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ancient test that recently re-surfaced #5425

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Conversation

rdettai
Copy link
Contributor

@rdettai rdettai commented Sep 13, 2024

Description

Kind of like the balrog that was awaken by the dwarfes mining mithril, this test was re-activated in CI by #5392.

The default sort order was inverted in https://github.com/quickwit-oss/quickwit/pull/3726/files and this dormant test was not updated accordingly.

How was this PR tested?

Test now passes.

@rdettai rdettai self-assigned this Sep 13, 2024
docs/internals/ingest-v2.md Show resolved Hide resolved
docs/overview/concepts/querying.md Outdated Show resolved Hide resolved
docs/overview/concepts/querying.md Outdated Show resolved Hide resolved
@rdettai
Copy link
Contributor Author

rdettai commented Sep 13, 2024

@rdettai rdettai enabled auto-merge (squash) September 13, 2024 15:52
@rdettai rdettai merged commit 6a61f55 into main Sep 13, 2024
5 checks passed
@rdettai rdettai deleted the fix-old-search-test branch September 13, 2024 15:59
Copy link

On SSD:

Average search latency is 0.985x that of the reference (lower is better).
Ref run id: 3417, ref commit: 8988310
Link

On GCS:

Average search latency is 0.998x that of the reference (lower is better).
Ref run id: 3418, ref commit: 8988310
Link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants