Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix builds with --all-features #5419

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Fix builds with --all-features #5419

merged 2 commits into from
Sep 13, 2024

Conversation

rdettai
Copy link
Contributor

@rdettai rdettai commented Sep 12, 2024

Description

https://github.com/quickwit-oss/quickwit/actions/runs/10788267700/job/29918676650

How was this PR tested?

Describe how you tested this PR.

@rdettai rdettai self-assigned this Sep 12, 2024
@rdettai rdettai added the build label Sep 12, 2024
Copy link
Contributor Author

@rdettai rdettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rdettai
Copy link
Contributor Author

rdettai commented Sep 12, 2024

Copy link

On SSD:

Average search latency is 0.984x that of the reference (lower is better).
Ref run id: 3395, ref commit: d142f59
Link

On GCS:

Average search latency is 1.04x that of the reference (lower is better).
Ref run id: 3396, ref commit: d142f59
Link

@rdettai
Copy link
Contributor Author

rdettai commented Sep 13, 2024

The coverage still fails because the test_single_node_several_splits test was re-activated by #5392 and the sort order of the search result actually changed since the test was written.

@rdettai rdettai merged commit 8988310 into main Sep 13, 2024
6 of 7 checks passed
@rdettai rdettai deleted the fix-codecov-ci branch September 13, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants