Fix configuration interpolation #5403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdettai
commented
Sep 9, 2024
| @@ -30,7 +30,7 @@ use tracing::debug; | |||
| // `ENV_VAR` or `ENV_VAR:DEFAULT` | |||
| // Ignores whitespaces in curly braces | |||
| static TEMPLATE_ENV_VAR_CAPTURE: Lazy<Regex> = Lazy::new(|| { | |||
| Regex::new(r"\$\{\s*([A-Za-z0-9_]+)\s*(?::\-\s*([\S]+)\s*)?}") | |||
There was a problem hiding this comment.
this is the only code change of this PR, the rest are tests
rdettai
force-pushed
the
fix-conf-templating
branch
from
f527b57
to
440f1e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The regex for env variable interpolation in configs doesn't capture properly multiple variables in the same line.
Closes #5403
How was this PR tested?
Unit test + tests in the lambda package