improve logging #5387
Merged
improve logging #5387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
log actual index_id patterns that are queried on leaf nodes reduce log spam
fulmicoton
approved these changes
Sep 10, 2024
fulmicoton
reviewed
Sep 10, 2024
| self.force_path_style_access, | ||
| ); | ||
| Some(force_path_style_access) | ||
| static FORCE_PATH_STYLE: OnceLock<Option<bool>> = OnceLock::new(); |
There was a problem hiding this comment.
Have you discovered if all that logging was justified? Is this normal that we created that many S3Storage?
There was a problem hiding this comment.
It was not unreasonable, but could be improved with caching, which is covered by #5377 (not sure if it completely resolves the issue)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
log actual index_id patterns that are queried on leaf nodes
reduce log spam