Reacquire SQS shards only if they are stale #5338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdettai
force-pushed
the
sqs-stale-shards
branch
from
a2ffa08
to
34dce73
Compare
rdettai
force-pushed
the
sqs-stale-shards
branch
from
34dce73
to
ce78565
Compare
fulmicoton
changed the title
fulmicoton
approved these changes
Aug 29, 2024
rdettai
force-pushed
the
shard-pruning
branch
from
92a8871
to
646c1b1
Compare
rdettai
force-pushed
the
sqs-stale-shards
branch
from
ce78565
to
66c1ca8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, shards are always reaquired when they re-appear in the SQS queue. We can limit this process to shards that are obviously stale based on their update timestamp.
How was this PR tested?
Added unit tests