Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add update timestamp to Shard model #5332

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Add update timestamp to Shard model #5332

merged 2 commits into from
Aug 27, 2024

Conversation

rdettai
Copy link
Contributor

@rdettai rdettai commented Aug 21, 2024

Description

For cleaning up old shards, we need to record the timestamp of the last modification.

How was this PR tested?

Adapted all the unit tests and backward compatibility tests.

@rdettai rdettai mentioned this pull request Aug 21, 2024
Open
4 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 21, 2024 •
edited
Loading

On SSD:

Average search latency is 0.998x that of the reference (lower is better).
Ref run id: 3029, ref commit: 0d4d143
Link

On GCS:

Average search latency is 0.994x that of the reference (lower is better).
Ref run id: 3030, ref commit: 0d4d143
Link

@rdettai rdettai self-assigned this Aug 22, 2024
@rdettai rdettai added the enhancement New feature or request label Aug 22, 2024
@rdettai rdettai enabled auto-merge (squash) August 27, 2024 11:54
@rdettai rdettai merged commit 948329b into main Aug 27, 2024
5 checks passed
@rdettai rdettai deleted the shard-update-timestamp branch August 27, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulmicoton fulmicoton fulmicoton approved these changes

Assignees

@rdettai rdettai

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rdettai @fulmicoton