Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file re-ingestion after EOF #5330

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Fix file re-ingestion after EOF #5330

merged 2 commits into from
Aug 20, 2024

Conversation

rdettai
Copy link
Contributor

@rdettai rdettai commented Aug 20, 2024

Description

When ingesting a file that was already indexed using the file source, the indexing should be a successful noop. We currently get an error.

How was this PR tested?

Describe how you tested this PR.

@rdettai rdettai self-assigned this Aug 20, 2024
@rdettai rdettai marked this pull request as ready for review August 20, 2024 12:03
Copy link

github-actions bot commented Aug 20, 2024

On SSD:

Average search latency is 1.01x that of the reference (lower is better).
Ref run id: 2894, ref commit: c59be63
Link

On GCS:

Average search latency is 1.02x that of the reference (lower is better).
Ref run id: 2895, ref commit: c59be63
Link

@rdettai rdettai enabled auto-merge (squash) August 20, 2024 12:50
@rdettai rdettai merged commit 108ad21 into main Aug 20, 2024
5 checks passed
@rdettai rdettai deleted the fix-file-ingest-eof branch August 20, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants