allow querying non existing fields #5308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdettai
reviewed
Aug 19, 2024
quickwit/quickwit-integration-tests/src/tests/update_tests/doc_mapping_tests.rs
Outdated
Show resolved
Hide resolved
|
we may make so we accept query on non-existing field only when lenient is true. This is different from what ES does, but there seems to be a consensus among us that what ES does here is not a behaviour we like (being too lenient by default) |
trinity-1686a
force-pushed
the
trinity/ignore-unknown-field
branch
from
fd239da
to
564e26f
Compare
This was referenced Aug 28, 2024
Closed
fulmicoton
reviewed
Aug 30, 2024
| @@ -45,8 +45,8 @@ pub(crate) struct MatchQueryParams { | |||
| // Regardless of this option Quickwit behaves in elasticsearch definition of | |||
There was a problem hiding this comment.
Can you edit the comment?
fulmicoton
reviewed
Aug 30, 2024
| #[serde(default, rename = "lenient")] | ||
| _lenient: bool, | ||
| #[serde(default)] | ||
| lenient: bool, |
There was a problem hiding this comment.
same as for match query. we need to edit the comment.
fulmicoton
reviewed
Aug 30, 2024
| @@ -99,6 +105,7 @@ fn convert_user_input_ast_to_query_ast( | |||
| user_input_ast: UserInputAst, | |||
There was a problem hiding this comment.
can you add some short documentation for this method?
fulmicoton
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #5302
the spec around update is a bit odd: we can search inside deleted fields (validation is okay with inexistant field, and mapping the query per-split actually find the field for older splits), but we don't return these fields
How was this PR tested?
updated ut, added it