Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure stalled stream protection #5301

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

trinity-1686a
Copy link
Contributor

Description

may fix #5294
configure StalledStreamProtectionConfig. For some reason, when unconfigured, the default grace period is 5s, but when configured, the default is 20s.
If this doesn't fix #5294, we can do

StalledStreamProtectionConfig::enabled()
    .upload_enabled(false)
    .build()

to restore pre march behaviour. I believe it would be best to keep this enabled if possible, as it allows earlier detection of dead connections.

How was this PR tested?

verified from aws debug logs that it picks the correct timeout

Copy link

github-actions bot commented Aug 6, 2024

On SSD:

Average search latency is 0.998x that of the reference (lower is better).
Ref run id: 2929, ref commit: 995bb62
Link

On GCS:

Average search latency is 0.977x that of the reference (lower is better).
Ref run id: 2930, ref commit: 995bb62
Link

@guilload guilload merged commit 60368df into main Aug 28, 2024
5 checks passed
@guilload guilload deleted the trinity/configure-stalled-stream-protection branch August 28, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS s3 stalled stream upload errors
2 participants