Clone a single Arc when cloning code-generated services
#5116
+1,545
−1,686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilload
force-pushed
the
guilload/clone-clone-clone
branch
from
e7f24f2
to
3b66d3f
Compare
guilload
force-pushed
the
guilload/clone-clone-clone
branch
from
3b66d3f
to
2e27ed3
Compare
fulmicoton
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The code-generated service traits no longer require the implementations to be
Cloneand no longer use mutable methods. This is very similar to what is done intonic. Stateful services must be implemented as actors (control plane) or use interior mutability (file-backed metastore, ingester, etc.).How was this PR tested?
It compiles!