-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compression cpu thread pool #4970
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fulmicoton
commented
May 10, 2024
•
edited
Loading
edited
fulmicoton
force-pushed
the
compression-cpu-thread-pool
branch
17 times, most recently
from
May 10, 2024 09:41
6c07817
to
6d65351
Compare
This PR removes usage of spawn_blocking for cpu intensive tasks. The problem with spawn_blocking is that these tasks get scheduled on a ever growing thread pool. For instance, when the server is under load, the GZIP decompression of payloads could considerably increase the load factor of quickwit, possibly making it unresponsive to healthcheck. This PR isolates the thread pool used for the searcher, and instantiates a second generic thread pool dedicated to those short cpu-intensive tasks.
fulmicoton
force-pushed
the
compression-cpu-thread-pool
branch
from
May 10, 2024 10:11
6d65351
to
006eb73
Compare
guilload
approved these changes
May 10, 2024
let span = tracing::Span::current(); | ||
let gauge = self.active_threads_gauge.clone(); | ||
let (tx, rx) = oneshot::channel(); | ||
self.thread_pool.spawn(move || { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Metric suggestion: number of queued "requests"
Co-authored-by: Adrien Guillo <[email protected]>
fulmicoton
force-pushed
the
compression-cpu-thread-pool
branch
from
May 11, 2024 02:05
f9f2c88
to
327a256
Compare
fulmicoton
added a commit
that referenced
this pull request
May 13, 2024
* Added a thread pool for ingest decompression * Running small but cpu intensive tasks in a thread pool. This PR removes usage of spawn_blocking for cpu intensive tasks. The problem with spawn_blocking is that these tasks get scheduled on a ever growing thread pool. For instance, when the server is under load, the GZIP decompression of payloads could considerably increase the load factor of quickwit, possibly making it unresponsive to healthcheck. This PR isolates the thread pool used for the searcher, and instantiates a second generic thread pool dedicated to those short cpu-intensive tasks. * Apply suggestions from code review Co-authored-by: Adrien Guillo <[email protected]> --------- Co-authored-by: Adrien Guillo <[email protected]>
fulmicoton
added a commit
that referenced
this pull request
May 14, 2024
* Added a thread pool for ingest decompression * Running small but cpu intensive tasks in a thread pool. This PR removes usage of spawn_blocking for cpu intensive tasks. The problem with spawn_blocking is that these tasks get scheduled on a ever growing thread pool. For instance, when the server is under load, the GZIP decompression of payloads could considerably increase the load factor of quickwit, possibly making it unresponsive to healthcheck. This PR isolates the thread pool used for the searcher, and instantiates a second generic thread pool dedicated to those short cpu-intensive tasks. * Apply suggestions from code review Co-authored-by: Adrien Guillo <[email protected]> --------- Co-authored-by: Adrien Guillo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.