Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing dependency to num_cpus (as the info is available in the std #4947

Merged
merged 2 commits into from
May 8, 2024
Merged

Removing dependency to num_cpus (as the info is available in the std #4947

merged 2 commits into from
May 8, 2024

Conversation

fulmicoton
Copy link
Contributor

nowadays).

trinity-1686a
trinity-1686a approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@trinity-1686a trinity-1686a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the documentation isn't very verbose on why can available_parallelism() fail. I'd be in favor of issuing a warn and returning a small default value instead of panicking

@fulmicoton fulmicoton merged commit 1b0c876 into main May 8, 2024
2 of 3 checks passed
@fulmicoton fulmicoton deleted the removing-num-cpus branch May 8, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trinity-1686a trinity-1686a trinity-1686a approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fulmicoton @trinity-1686a