Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow updating of doc mapper #4928

Closed
wants to merge 4 commits into from
Closed

Conversation

trinity-1686a
Copy link
Contributor

@trinity-1686a trinity-1686a commented Apr 30, 2024

Description

this pr aims at laying the foundation work for updating the doc mapping of an index

  • store a doc mapper version in the doc mapper
  • store a doc mapper version in splits meta
  • allow updating the doc mapper, auto-incrementing its version (metastore level)
  • allow updating the doc mapper (api level)
  • block merges between multiple version of a doc mapper
  • restart ingestion pipeline so they notice the change in doc mapper decently quickly (stretch goal, maybe put in a 2nd pull request)

How was this PR tested?

  • test we properly block merges (unit tests)
  • test we properly block merges (integration tests)
  • test modifying different properties (tokenizer, what is stored...), and how it breaks (or not) search

@rdettai
Copy link
Contributor

rdettai commented May 6, 2024

We should probably merge #4868 before addressing:

  • allow updating the doc mapper (api level)

@trinity-1686a
Copy link
Contributor Author

we are going to ship this in multiple smaller PR, which means this should be ready for review

@trinity-1686a trinity-1686a marked this pull request as ready for review June 5, 2024 14:06
Copy link

github-actions bot commented Jun 5, 2024

On SSD:

Average search latency is 0.99x that of the reference (lower is better).
Ref run id: 1883, ref commit: 01571db
Link

On GCS:

Average search latency is 1.0x that of the reference (lower is better).
Ref run id: 1884, ref commit: 01571db
Link

@trinity-1686a
Copy link
Contributor Author

made hard to work on by addition of doc_mapping_uid in a different PR. Remade from scratch in #5218

@trinity-1686a trinity-1686a deleted the trinity/update-mapper branch July 12, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants