Batch index_metadata calls in indexing service
#4921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilload
changed the title
index_metadata call in indexing serviceindex_metadata calls in indexing service
guilload
force-pushed
the
guilload/batch-index-metadata-metastore-calls
branch
2 times, most recently
from
82b74e2
to
5724e0c
Compare
fulmicoton
reviewed
Apr 29, 2024
fulmicoton
reviewed
Apr 29, 2024
fulmicoton
reviewed
Apr 29, 2024
quickwit/quickwit-metastore/src/metastore/index_metadata/mod.rs
Outdated
Show resolved
Hide resolved
fulmicoton
reviewed
Apr 29, 2024
fulmicoton
reviewed
Apr 29, 2024
fulmicoton
reviewed
Apr 29, 2024
quickwit/quickwit-metastore/src/metastore/postgres/metastore.rs
Outdated
Show resolved
Hide resolved
fulmicoton
requested changes
Apr 29, 2024
|
This PR showed a regression on simian so I pulled it off of today's test with airmail. With This was working on qw-airmail-20240423 |
|
Would you happen to have a clue as to what this PR is breaking? |
|
@guilload no clue. I did not dig further. I can redo the test if you want. |
guilload
force-pushed
the
guilload/batch-index-metadata-metastore-calls
branch
3 times, most recently
from
5f21d28
to
e5578bd
Compare
fulmicoton
approved these changes
May 9, 2024
|
I confirm it now works normally. |
guilload
force-pushed
the
guilload/batch-index-metadata-metastore-calls
branch
3 times, most recently
from
dc6e697
to
e1bc348
Compare
guilload
force-pushed
the
guilload/batch-index-metadata-metastore-calls
branch
from
e1bc348
to
3626621
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a batch
indexes_metadataAPI to the metastore and use it in the indexing service when spawning new indexing pipelines upon applying a new indexing plan.How was this PR tested?
Added unit test