Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add terraform module for ECS #4765

Merged
merged 4 commits into from
Apr 10, 2024
Merged

Add terraform module for ECS #4765

merged 4 commits into from
Apr 10, 2024

Conversation

rdettai
Copy link
Contributor

@rdettai rdettai commented Mar 20, 2024

Description

Add Terraform scripts with:

  • a module that can be used to deploy a general purpose Quickwit setup using ECS and RDS
  • an self contained example stack that uses that module and includes supporting network configurations (VPC and bastion)

How was this PR tested?

Executed on AWS with various configurations.

@rdettai rdettai self-assigned this Mar 20, 2024
@rdettai rdettai requested a review from fmassot March 20, 2024 10:59
@rdettai rdettai requested review from trinity-1686a and removed request for fmassot March 28, 2024 17:19
trinity-1686a
trinity-1686a reviewed Mar 30, 2024
View reviewed changes
Copy link
Contributor

@trinity-1686a trinity-1686a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks sensible, though I lack knowledge in terraform to confidently review that kind of PR

distribution/ecs/README.md Outdated Show resolved Hide resolved
distribution/ecs/README.md Outdated Show resolved Hide resolved
distribution/ecs/README.md Outdated Show resolved Hide resolved
distribution/ecs/example/bastion.tf Show resolved Hide resolved
distribution/ecs/example/kafka.tf Outdated Show resolved Hide resolved
distribution/ecs/example/logging.tf Outdated Show resolved Hide resolved
rdettai
rdettai commented Apr 2, 2024
View reviewed changes
distribution/ecs/README.md Outdated Show resolved Hide resolved
@rdettai rdettai enabled auto-merge (squash) April 10, 2024 07:45
@rdettai rdettai merged commit 0bb20f3 into main Apr 10, 2024
4 checks passed
@rdettai rdettai deleted the ecs-distribution branch April 10, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trinity-1686a trinity-1686a trinity-1686a approved these changes

Assignees

@rdettai rdettai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rdettai @trinity-1686a