Make io limits for merges a node-level parameter. #4440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
force-pushed
the
issue/4439-merge-io-limits
branch
from
4432e0a
to
ca59658
Compare
fulmicoton
force-pushed
the
issue/4439-merge-io-limits
branch
from
ca59658
to
bd16bbf
Compare
guilload
approved these changes
Jan 22, 2024
| @@ -91,6 +91,11 @@ pub struct IndexerConfig { | |||
| pub split_store_max_num_splits: usize, | |||
| #[serde(default = "IndexerConfig::default_max_concurrent_split_uploads")] | |||
| pub max_concurrent_split_uploads: usize, | |||
| /// Limits the IO throughput of the `SplitDownloader` and the `MergeExecutor`. | |||
| /// On hardware where IO is constraints, it makes sure that Merges (a batch operation) | |||
There was a problem hiding this comment.
Suggested change
| /// On hardware where IO is constraints, it makes sure that Merges (a batch operation) | |
| /// On hardware where IO is constrained, it makes sure that Merges (a batch operation) |
fulmicoton
force-pushed
the
issue/4439-merge-io-limits
branch
from
6fb8b59
to
fd7750e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also removes the index label from the IO metrics. It also removes the limits for the delete pipeline.
Closes #4439