Implement Shard API for PostgreSQL metastore #4403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilload
force-pushed
the
guilload/pg-list-shards
branch
6 times, most recently
from
457179d
to
b166a25
Compare
guilload
force-pushed
the
guilload/pg-list-shards
branch
from
b166a25
to
3616d6c
Compare
guilload
force-pushed
the
guilload/pg-list-shards
branch
from
3616d6c
to
15f5887
Compare
fulmicoton
reviewed
Jan 18, 2024
quickwit/quickwit-metastore/src/metastore/file_backed/file_backed_index/shards.rs
Show resolved
Hide resolved
fulmicoton
reviewed
Jan 18, 2024
| > | ||
| ); | ||
| // crate::metastore_test_suite!( | ||
| // quickwit_proto::metastore::MetastoreServiceGrpcClientAdapter< |
There was a problem hiding this comment.
I will in my next PR. It's tricky because we only have access to the client here but the tests required the insertion of shards in the server via an API that does not exist client-side and makes no sense to add.
fulmicoton
reviewed
Jan 18, 2024
fulmicoton
approved these changes
Jan 18, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
postgresql_metastorefile because it was becoming hard to navigateHow was this PR tested?
Added a bunch of unit tests