Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add max_queue_disk_usage check #4324

Merged
merged 4 commits into from
Dec 27, 2023
Merged

add max_queue_disk_usage check #4324

merged 4 commits into from
Dec 27, 2023

Conversation

PSeitz
Copy link
Contributor

@PSeitz PSeitz commented Dec 26, 2023 •
edited
Loading

  • validate max_queue_disk_usage
  • update docs

closes #4287

@PSeitz PSeitz requested a review from fmassot December 26, 2023 05:14
@PSeitz
Copy link
Contributor Author

PSeitz commented Dec 26, 2023

@fmassot Can the in memory queue be larger than disk? I added a check, but the docs state "This is typically higher than the max in-memory queue."

@fmassot
Copy link
Contributor

fmassot commented Dec 26, 2023

This new check is a nice addition.

@PSeitz PSeitz enabled auto-merge (squash) December 27, 2023 13:47
@PSeitz PSeitz merged commit 2480104 into main Dec 27, 2023
4 checks passed
@PSeitz PSeitz deleted the forward_error branch December 27, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassot fmassot fmassot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

document and add a validation chekc for the size of the mrecordlog queue.
2 participants
@PSeitz @fmassot