Add parameter to limit the size of a query string #4320
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added the parameter to limit the size of the query string in a user input. Further, I moved
validate_request
out of the for loop since many of the checks inside it did not require to be run for each index_metadata.An alternate approach for checking the query size could be to match the enums in the serialized query_ast value and check the size of the actual user input.
How was this PR tested?
New unit tests to check if the error is thrown.