Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url decode the search index pattern #4292

Merged
merged 8 commits into from
Dec 20, 2023
Merged

Conversation

tuziben
Copy link
Collaborator

@tuziben tuziben commented Dec 18, 2023

Description

Trying to fix this issue #4291

How was this PR tested?

Describe how you tested this PR.

@tuziben tuziben requested a review from fmassot December 18, 2023 08:51
@fmassot
Copy link
Contributor

fmassot commented Dec 18, 2023

@tuziben indeed warp does not decode the path string, we have to do it ourselves.
Can we use percent_decode from this crate instead of the urlencoding crate?

@tuziben
Copy link
Collaborator Author

tuziben commented Dec 18, 2023

@tuziben indeed warp does not decode the path string, we have to do it ourselves. Can we use percent_decode from this crate instead of the urlencoding crate?

OK, I will refine this part.

@tuziben tuziben requested a review from fmassot December 19, 2023 01:41
Copy link
Contributor

@fmassot fmassot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tuziben !

@fmassot fmassot enabled auto-merge (squash) December 20, 2023 08:10
@fmassot fmassot merged commit fbe8dab into main Dec 20, 2023
4 checks passed
@fmassot fmassot deleted the tuziben/decode_index_pattern branch December 20, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants