feat: add jaeger rest endpoints for grafana tracing support #4197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etolbakov
commented
Nov 27, 2023
etolbakov
commented
Nov 28, 2023
fmassot
reviewed
Nov 30, 2023
fmassot
reviewed
Nov 30, 2023
| .map(|result| make_jaeger_api_response(result, BodyFormat::default())) | ||
| } | ||
|
|
||
| /// GET otel-traces-v0_6/traces/{trace-id-base-64} |
There was a problem hiding this comment.
I would avoid putting the "otel-traces-v0_6/traces/{trace-id-base-64}" in comment, if we do correctly the openapi stuff it should be sufficient.
Just say "Get trace by ID", it's singular.
fmassot
reviewed
Nov 30, 2023
| .into_inner(); | ||
|
|
||
| Ok(JaegerSearchBody { | ||
| data: Some(get_operations_response.operation_names), |
There was a problem hiding this comment.
operation names is empty, it's a bit strange. if you take get_operations_response.operations.into_iter().map(|op| op.name).collect_vec() instead, it will work in grafana
@guilload did you see this weird empty operation name list?
fmassot
reviewed
Dec 2, 2023
fmassot
reviewed
Dec 2, 2023
fmassot
reviewed
Dec 2, 2023
fmassot
reviewed
Dec 2, 2023
fmassot
reviewed
Dec 2, 2023
fmassot
reviewed
Dec 2, 2023
fmassot
reviewed
Dec 2, 2023
|
Checked the swagger UI, the image below |
Refactor parse duration for jaeger.
fmassot
reviewed
Dec 20, 2023
fmassot
reviewed
Dec 20, 2023
fmassot
reviewed
Dec 20, 2023
fmassot
approved these changes
Dec 21, 2023
|
😅🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add jaeger rest endpoints for grafana tracing support
TODO:
go_parse_durationdependencyutil.rsintomodels.rs(can we get rid of some of them?)Related issues:
quickwit-oss/quickwit-datasource#5