Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix #4043

Merged
merged 3 commits into from
Oct 28, 2023
Merged

Bugfix #4043

merged 3 commits into from
Oct 28, 2023

Conversation

fulmicoton
Copy link
Contributor

  • Update the control plane model on toggle source.
  • Delete source from index config in control plane model on delete source.

@fulmicoton
Bugfix
32325df 
- Update the control plane model on toggle source.
- Delete source from index config in control plane model
on delete source.
guilload
guilload approved these changes Oct 28, 2023
View reviewed changes
quickwit/quickwit-control-plane/src/control_plane.rs Show resolved Hide resolved
quickwit/quickwit-control-plane/src/control_plane_model.rs Outdated Show resolved Hide resolved
quickwit/quickwit-control-plane/src/control_plane_model.rs Outdated Show resolved Hide resolved
quickwit/quickwit-control-plane/src/control_plane_model.rs Outdated
bail!("Source `{}` not found.", source_id);
};
source_config.enabled = enable;
Ok(enable)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not return whether the source has changed but rather whether it was enabled or not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a bug indeed.

@fulmicoton fulmicoton enabled auto-merge (squash) October 28, 2023 08:23
@fulmicoton fulmicoton merged commit ee33492 into main Oct 28, 2023
4 checks passed
@fulmicoton fulmicoton deleted the bugfix-toggle-source branch October 28, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guilload guilload guilload approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fulmicoton @guilload