Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Observe messages from stacking up #3765

Merged
merged 3 commits into from
Aug 20, 2023
Merged

Conversation

fulmicoton
Copy link
Contributor

@fulmicoton fulmicoton commented Aug 18, 2023

Prevents Observe message emitted by Supervisors from stacking up

This introduce a refresh observation method, that does not wait
for anything but just triggers an eventual refresh of the last
observation.

This method includes debouncing logic to avoid stacking up messages.

We then use it in supervisors, which the other merit of making the
Supervise handler return much faster.

Before we were waiting for the observation to timeout.

Closes #3485

@fulmicoton fulmicoton force-pushed the issue/3485-observe branch 7 times, most recently from ee365a4 to f1cfeab Compare August 18, 2023 03:18
@guilload guilload changed the title Issue/3485 observe Prevent observe messages from stacking up Aug 18, 2023
@guilload guilload changed the title Prevent observe messages from stacking up Prevent Observe messages from stacking up Aug 18, 2023
This introduce a refresh observation method, that does not wait
for anything but just triggers an eventual refresh of the last
observation.

This method includes debouncing logic to avoid stacking up messages.

We then use it in supervisors, which the other merit of making the
Supervise handler return much faster.

Before we were waiting for the observation to timeout.

Closes #3485
@fulmicoton fulmicoton merged commit c4ca94a into main Aug 20, 2023
3 checks passed
@fulmicoton fulmicoton deleted the issue/3485-observe branch August 20, 2023 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Observation messages are stacking up
2 participants