Add coerce and output format options for numeric fields #3704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilload
force-pushed
the
guilload/int-input-output-format
branch
from
3b7aec6
to
407f1cc
Compare
fulmicoton
reviewed
Aug 3, 2023
quickwit/quickwit-doc-mapper/src/default_doc_mapper/mapping_tree.rs
Outdated
Show resolved
Hide resolved
fulmicoton
reviewed
Aug 3, 2023
quickwit/quickwit-doc-mapper/src/default_doc_mapper/mapping_tree.rs
Outdated
Show resolved
Hide resolved
fulmicoton
approved these changes
Aug 3, 2023
guilload
force-pushed
the
guilload/int-input-output-format
branch
from
407f1cc
to
dbcc041
Compare
|
Maybe I should have named the parameter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
coerceoption to convert string values to numeric values for numerics fields by default.output_formatoption to output numeric values as stringsI will update the doc when we agree on the spec.
How was this PR tested?
Add unit tests