Remove unnecessary Sync bounds in actor framework
#3601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trinity-1686a
approved these changes
Jul 4, 2023
| /// Piece of state that can be copied for assert in unit test, admin, etc. | ||
| type ObservableState: Send + Sync + Clone + serde::Serialize + fmt::Debug; | ||
| type ObservableState: fmt::Debug + serde::Serialize + Send + Sync + Clone; |
There was a problem hiding this comment.
does the observable state needs to be Sync?
There was a problem hiding this comment.
Yes, it needs to be Sync because of the watch channel. Under the hood, it's using a RwLock, I found out the hard way in the parking_lot documentation:
The type parameter
Trepresents the data that this lock protects. It is
/// required thatTsatisfiesSendto be shared across threads andSyncto
/// allow concurrent access through readers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Syncbecause they're behind channels and process messages sequentiallySynceither.I used
SyncWrapperin this PR to make the actor loop futureSync.How was this PR tested?
make test-all