update mrecordlog to 0.4 #3600
Merged
update mrecordlog to 0.4 #3600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update mrecordlog to a newer version, with better resilience to corrupted wal.
fix #3589
How was this PR tested?
I created an index, ingested a few gigabytes worth of data, killed quickwit and overwrote a few bytes in the file. I then restarted quickwit. When ingestion ended, I compared result to a normal ingestion. It lost 2319 docs (8.5MB), which is about one call to
append_records, the smallest unit of data in mrecordlog.