Mini refactor checklist->quickwit-cli #3597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
force-pushed
the
checklist-in-cli
branch
from
d218bcc
to
2af7f4c
Compare
fmassot
approved these changes
Jul 3, 2023
fulmicoton
force-pushed
the
checklist-in-cli
branch
from
2af7f4c
to
9ccec26
Compare
Rationale: - checklist is only used by quickwit-cli. - checklist pulls the colored dependency.
fulmicoton
force-pushed
the
checklist-in-cli
branch
from
9ccec26
to
0d99456
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving checklist out of quickwit-common and into quickwit-cli
Rationale: