Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingest V2 misses commit wait_for #5351

Closed
rdettai opened this issue Aug 27, 2024 · 2 comments · Fixed by #5359
Closed

Ingest V2 misses commit wait_for #5351

rdettai opened this issue Aug 27, 2024 · 2 comments · Fixed by #5359
Labels
bug Something isn't working

Comments

@rdettai
Copy link
Contributor

rdettai commented Aug 27, 2024

Is your feature request related to a problem? Please describe.
Similar to #4438 that tracks the behavior of CommitType::Force in ingest V2, this issue is about CommitType::wait in ingest V2. See the docs for the specs.

Describe the solution you'd like
Ingest V2 should behave like ingest V1 when using ?commit=wait_for

Describe alternatives you've considered
Remove the feature for ingest V2.

Additional context
With ingest V1, indexing was happening on the same node as the one receiving the query. This is not true anymore with ingest V2, so the notification system that makes the waiting possible should happen at the cluster level. Possible solutions:

  • track commit progress and push notifications from the control plane
  • communicate back the commits directly from the indexer to the original ingester
@rdettai rdettai added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Aug 27, 2024
@rdettai
Copy link
Contributor Author

rdettai commented Aug 27, 2024

#4438 (comment)

@rdettai rdettai linked a pull request Aug 28, 2024 that will close this issue
@rdettai rdettai closed this as completed Aug 28, 2024
@rdettai
Copy link
Contributor Author

rdettai commented Aug 28, 2024

this will be done as part of #5350 as commit=force also requires to wait

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant