Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloning IngestRouter and Ingester is not cheap #5114

Closed
guilload opened this issue Jun 12, 2024 · 1 comment
Closed

Cloning IngestRouter and Ingester is not cheap #5114

guilload opened this issue Jun 12, 2024 · 1 comment
Assignees
@guilload
Labels
bug Something isn't working

Comments

@guilload
Copy link
Member

Showed up during profiling. This is not surprising since those objects are quite complex and composed of also not so cheap to clone objects (ControlPlaneServiceTowerServiceStack). struct Foo { inner: Arc<InnerFoo> } is probably the way to go.
@guilload guilload added the bug Something isn't working label Jun 12, 2024
@guilload guilload self-assigned this Jun 12, 2024
@guilload
Copy link
Member Author

Closed via #5116.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guilload guilload

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@guilload