Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tags and service name to derive a process ID in the jaeger REST API #4314

Open
fmassot opened this issue Dec 21, 2023 · 0 comments
Open

Use tags and service name to derive a process ID in the jaeger REST API #4314

fmassot opened this issue Dec 21, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@fmassot
Copy link
Contributor

fmassot commented Dec 21, 2023 •
edited
Loading

We added in #4197 Jaeger REST endpoints.

The code logic used to convert gRPC objects into the REST ones has a missing part. During the conversion, we build process IDs from the service name, we should also take into account tags to build those IDs, ref
@fmassot fmassot added enhancement New feature or request good first issue Good for newcomers labels Dec 21, 2023
@fmassot fmassot changed the title Move jaeger REST code logic into the quickwit-jaeger project Use tags and service name to build a process ID in the jaeger REST API Dec 21, 2023
@fmassot fmassot changed the title Use tags and service name to build a process ID in the jaeger REST API Use tags and service name to derive a process ID in the jaeger REST API Dec 21, 2023
ph added a commit to ph/quickwit that referenced this issue Apr 3, 2024
@ph
Use tags and service_name to derive the process ID in the jaeger rest…
27d30de 
… api.

closes: quickwit-oss#4314
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fmassot