From 84572ea5955ecbe2b0d57ae5a1fbe5d5600ce716 Mon Sep 17 00:00:00 2001
From: Paul Masurel <paul@quickwit.io>
Date: Tue, 2 Jul 2024 19:29:47 +0900
Subject: [PATCH] Making all metastore tests serial (#5185)

---
 quickwit/quickwit-metastore/src/tests/mod.rs | 40 ++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/quickwit/quickwit-metastore/src/tests/mod.rs b/quickwit/quickwit-metastore/src/tests/mod.rs
index 4a579f12eac..b4878a1b978 100644
--- a/quickwit/quickwit-metastore/src/tests/mod.rs
+++ b/quickwit/quickwit-metastore/src/tests/mod.rs
@@ -189,30 +189,35 @@ macro_rules! metastore_test_suite {
             }
 
             #[tokio::test]
+            #[serial_test::serial]
             async fn test_metastore_create_index_with_sources() {
                 let _ = tracing_subscriber::fmt::try_init();
                 $crate::tests::index::test_metastore_create_index_with_sources::<$metastore_type>().await;
             }
 
             #[tokio::test]
+            #[serial_test::serial]
             async fn test_metastore_update_retention_policy() {
                 let _ = tracing_subscriber::fmt::try_init();
                 $crate::tests::index::test_metastore_update_retention_policy::<$metastore_type>().await;
             }
 
             #[tokio::test]
+            #[serial_test::serial]
             async fn test_metastore_update_search_settings() {
                 let _ = tracing_subscriber::fmt::try_init();
                 $crate::tests::index::test_metastore_update_search_settings::<$metastore_type>().await;
             }
 
             #[tokio::test]
+            #[serial_test::serial]
             async fn test_metastore_update_indexing_settings() {
                 let _ = tracing_subscriber::fmt::try_init();
                 $crate::tests::index::test_metastore_update_indexing_settings::<$metastore_type>().await;
             }
 
             #[tokio::test]
+            #[serial_test::serial]
             async fn test_metastore_create_index_enforces_index_id_maximum_length() {
                 let _ = tracing_subscriber::fmt::try_init();
                 $crate::tests::index::test_metastore_create_index_enforces_index_id_maximum_length::<
@@ -222,36 +227,42 @@ macro_rules! metastore_test_suite {
             }
 
             #[tokio::test]
+            #[serial_test::serial]
             async fn test_metastore_index_exists() {
                 let _ = tracing_subscriber::fmt::try_init();
                 $crate::tests::index::test_metastore_index_exists::<$metastore_type>().await;
             }
 
             #[tokio::test]
+            #[serial_test::serial]
             async fn test_metastore_index_metadata() {
                 let _ = tracing_subscriber::fmt::try_init();
                 $crate::tests::index::test_metastore_index_metadata::<$metastore_type>().await;
             }
 
             #[tokio::test]
+            #[serial_test::serial]
             async fn test_metastore_indexes_metadata() {
                 let _ = tracing_subscriber::fmt::try_init();
                 $crate::tests::index::test_metastore_indexes_metadata::<$metastore_type>().await;
             }
 
             #[tokio::test]
+            #[serial_test::serial]
             async fn test_metastore_list_indexes() {
                 let _ = tracing_subscriber::fmt::try_init();
                 $crate::tests::index::test_metastore_list_indexes::<$metastore_type>().await;
             }
 
             #[tokio::test]
+            #[serial_test::serial]
             async fn test_metastore_list_all_indexes() {
                 let _ = tracing_subscriber::fmt::try_init();
                 $crate::tests::index::test_metastore_list_all_indexes::<$metastore_type>().await;
             }
 
             #[tokio::test]
+            #[serial_test::serial]
             async fn test_metastore_delete_index() {
                 let _ = tracing_subscriber::fmt::try_init();
                 $crate::tests::index::test_metastore_delete_index::<$metastore_type>().await;
@@ -266,12 +277,14 @@ macro_rules! metastore_test_suite {
             //  - delete_splits
 
             #[tokio::test]
+            #[serial_test::serial]
             async fn test_metastore_publish_splits() {
                 let _ = tracing_subscriber::fmt::try_init();
                 $crate::tests::split::test_metastore_publish_splits::<$metastore_type>().await;
             }
 
             #[tokio::test]
+            #[serial_test::serial]
             async fn test_metastore_publish_splits_concurrency() {
                 let _ = tracing_subscriber::fmt::try_init();
                 $crate::tests::split::test_metastore_publish_splits_concurrency::<$metastore_type>(
@@ -280,6 +293,7 @@ macro_rules! metastore_test_suite {
             }
 
             #[tokio::test]
+            #[serial_test::serial]
             async fn test_metastore_publish_splits_empty_splits_array_is_allowed() {
                 $crate::tests::split::test_metastore_publish_splits_empty_splits_array_is_allowed::<
                             $metastore_type,
@@ -288,12 +302,14 @@ macro_rules! metastore_test_suite {
             }
 
             #[tokio::test]
+            #[serial_test::serial]
             async fn test_metastore_replace_splits() {
                 let _ = tracing_subscriber::fmt::try_init();
                 $crate::tests::split::test_metastore_replace_splits::<$metastore_type>().await;
             }
 
             #[tokio::test]
+            #[serial_test::serial]
             async fn test_metastore_mark_splits_for_deletion() {
                 let _ = tracing_subscriber::fmt::try_init();
                 $crate::tests::split::test_metastore_mark_splits_for_deletion::<$metastore_type>()
@@ -301,36 +317,43 @@ macro_rules! metastore_test_suite {
             }
 
             #[tokio::test]
+            #[serial_test::serial]
             async fn test_metastore_delete_splits() {
                 let _ = tracing_subscriber::fmt::try_init();
                 $crate::tests::split::test_metastore_delete_splits::<$metastore_type>().await;
             }
 
             #[tokio::test]
+            #[serial_test::serial]
             async fn test_metastore_stream_splits() {
                 let _ = tracing_subscriber::fmt::try_init();
                 $crate::tests::list_splits::test_metastore_stream_splits::<$metastore_type>().await;
             }
 
             #[tokio::test]
+            #[serial_test::serial]
             async fn test_metastore_list_all_splits() {
                 let _ = tracing_subscriber::fmt::try_init();
                 $crate::tests::list_splits::test_metastore_list_all_splits::<$metastore_type>().await;
             }
 
             #[tokio::test]
+            #[serial_test::serial]
             async fn test_metastore_list_splits() {
                 let _ = tracing_subscriber::fmt::try_init();
                 $crate::tests::list_splits::test_metastore_list_splits::<$metastore_type>().await;
             }
 
+
             #[tokio::test]
+            #[serial_test::serial]
             async fn test_metastore_list_splits_by_node() {
                 let _ = tracing_subscriber::fmt::try_init();
                 $crate::tests::list_splits::test_metastore_list_splits_by_node_id::<$metastore_type>().await;
             }
 
             #[tokio::test]
+            #[serial_test::serial]
             async fn test_metastore_split_update_timestamp() {
                 let _ = tracing_subscriber::fmt::try_init();
                 $crate::tests::split::test_metastore_split_update_timestamp::<$metastore_type>()
@@ -338,60 +361,70 @@ macro_rules! metastore_test_suite {
             }
 
             #[tokio::test]
+            #[serial_test::serial]
             async fn test_metastore_add_source() {
                 let _ = tracing_subscriber::fmt::try_init();
                 $crate::tests::source::test_metastore_add_source::<$metastore_type>().await;
             }
 
             #[tokio::test]
+            #[serial_test::serial]
             async fn test_metastore_toggle_source() {
                 let _ = tracing_subscriber::fmt::try_init();
                 $crate::tests::source::test_metastore_toggle_source::<$metastore_type>().await;
             }
 
             #[tokio::test]
+            #[serial_test::serial]
             async fn test_metastore_delete_source() {
                 let _ = tracing_subscriber::fmt::try_init();
                 $crate::tests::source::test_metastore_delete_source::<$metastore_type>().await;
             }
 
             #[tokio::test]
+            #[serial_test::serial]
             async fn test_metastore_reset_checkpoint() {
                 let _ = tracing_subscriber::fmt::try_init();
                 $crate::tests::source::test_metastore_reset_checkpoint::<$metastore_type>().await;
             }
 
             #[tokio::test]
+            #[serial_test::serial]
             async fn test_metastore_create_delete_task() {
                 let _ = tracing_subscriber::fmt::try_init();
                 $crate::tests::delete_task::test_metastore_create_delete_task::<$metastore_type>().await;
             }
 
             #[tokio::test]
+            #[serial_test::serial]
             async fn test_metastore_last_delete_opstamp() {
                 let _ = tracing_subscriber::fmt::try_init();
                 $crate::tests::delete_task::test_metastore_last_delete_opstamp::<$metastore_type>().await;
             }
 
             #[tokio::test]
+            #[serial_test::serial]
             async fn test_metastore_delete_index_with_tasks() {
                 let _ = tracing_subscriber::fmt::try_init();
                 $crate::tests::delete_task::test_metastore_delete_index_with_tasks::<$metastore_type>().await;
             }
 
             #[tokio::test]
+            #[serial_test::serial]
             async fn test_metastore_list_delete_tasks() {
                 let _ = tracing_subscriber::fmt::try_init();
                 $crate::tests::delete_task::test_metastore_list_delete_tasks::<$metastore_type>().await;
             }
 
             #[tokio::test]
+            #[serial_test::serial]
             async fn test_metastore_list_stale_splits() {
                 let _ = tracing_subscriber::fmt::try_init();
                 $crate::tests::list_splits::test_metastore_list_stale_splits::<$metastore_type>().await;
             }
 
             #[tokio::test]
+            #[serial_test::serial]
             async fn test_metastore_update_splits_delete_opstamp() {
                 let _ = tracing_subscriber::fmt::try_init();
                 $crate::tests::split::test_metastore_update_splits_delete_opstamp::<$metastore_type>()
@@ -399,6 +432,7 @@ macro_rules! metastore_test_suite {
             }
 
             #[tokio::test]
+            #[serial_test::serial]
             async fn test_metastore_stage_splits() {
                 let _ = tracing_subscriber::fmt::try_init();
                 $crate::tests::split::test_metastore_stage_splits::<$metastore_type>().await;
@@ -407,31 +441,37 @@ macro_rules! metastore_test_suite {
             /// Shard API tests
 
             #[tokio::test]
+            #[serial_test::serial]
             async fn test_metastore_open_shards() {
                 $crate::tests::shard::test_metastore_open_shards::<$metastore_type>().await;
             }
 
             #[tokio::test]
+            #[serial_test::serial]
             async fn test_metastore_acquire_shards() {
                 $crate::tests::shard::test_metastore_acquire_shards::<$metastore_type>().await;
             }
 
             #[tokio::test]
+            #[serial_test::serial]
             async fn test_metastore_list_shards() {
                 $crate::tests::shard::test_metastore_list_shards::<$metastore_type>().await;
             }
 
             #[tokio::test]
+            #[serial_test::serial]
             async fn test_metastore_delete_shards() {
                 $crate::tests::shard::test_metastore_delete_shards::<$metastore_type>().await;
             }
 
             #[tokio::test]
+            #[serial_test::serial]
             async fn test_metastore_apply_checkpoint_delta_v2_single_shard() {
                 $crate::tests::shard::test_metastore_apply_checkpoint_delta_v2_single_shard::<$metastore_type>().await;
             }
 
             #[tokio::test]
+            #[serial_test::serial]
             async fn test_metastore_apply_checkpoint_delta_v2_multi_shards() {
                 $crate::tests::shard::test_metastore_apply_checkpoint_delta_v2_multi_shards::<$metastore_type>().await;
             }