From 82fb6a2c5f0e3a382a2b5483a3c85b7a39a0f11f Mon Sep 17 00:00:00 2001 From: Paul Masurel Date: Mon, 26 Feb 2024 10:42:41 +0900 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Adrien "Code Monkey" Guillo --- quickwit/quickwit-indexing/src/models/shard_positions.rs | 4 ++-- quickwit/quickwit-serve/src/lib.rs | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/quickwit/quickwit-indexing/src/models/shard_positions.rs b/quickwit/quickwit-indexing/src/models/shard_positions.rs index 1a0b3db367d..3199265ef1c 100644 --- a/quickwit/quickwit-indexing/src/models/shard_positions.rs +++ b/quickwit/quickwit-indexing/src/models/shard_positions.rs @@ -143,11 +143,11 @@ impl Actor for ShardPositionsService { .await, ); - // We are now listening to new updates. However the cluster has been started earlier. + // We are now listening to new updates. However, the cluster has been started earlier. // It might have already received shard updates from other nodes. // // Let's also sync our `ShardPositionsService` with the current state of the cluster. - // Shard positions update are trivially idempotent, so we can just replay all the events, + // Shard position updates are trivially idempotent, so we can replay all the events, // without worrying about duplicates. let now = Instant::now(); diff --git a/quickwit/quickwit-serve/src/lib.rs b/quickwit/quickwit-serve/src/lib.rs index f95385ced0a..80cf970f886 100644 --- a/quickwit/quickwit-serve/src/lib.rs +++ b/quickwit/quickwit-serve/src/lib.rs @@ -321,7 +321,7 @@ fn start_shard_positions_service( spawn_ctx: SpawnContext, ) { // We spawn a task here, because we need the ingester to be ready before spawning the - // the `ShardPositionsService`. If we don't all, all of the event we emit will be dismissed. + // the `ShardPositionsService`. If we don't, all the events we emit too early will be dismissed. tokio::spawn(async move { if let Some(ingester_service) = ingester_service_opt { if wait_for_ingester_status(ingester_service, IngesterStatus::Ready)