Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose TimeOfDay / TimeRange structs from time_range.go #441

Open
MattLicense3 opened this issue Jun 17, 2021 · 0 comments
Open

Expose TimeOfDay / TimeRange structs from time_range.go #441

MattLicense3 opened this issue Jun 17, 2021 · 0 comments

Comments

@MattLicense3
Copy link

MattLicense3 commented Jun 17, 2021

Recently I've found the need to look at the FIX session's configured start / end time. Essentially we have use a shared FIX client across multiple connections with different start/end times, and we're looking to trigger an alert if we receive a logout message during the session time e.g.

func (fa *FixApplication) OnLogout() {
	if fa.inSessionTime() {
		fa.SendAlert("FIX session logged out during session time")
	}
}

Currently that involves us re-parsing the Start/End time config from the session, where this is already done in time_range.go in the internal package. I believe it would be useful to move time_range.go to another package that is exported for public usage, though I'm unsure if there is any specific reason that it hasn't been exported currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant