-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fields optimization #37
Open
charlesbr1
wants to merge
15
commits into
quickfix-j:master
Choose a base branch
from
charlesbr1:fields-optimization
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A cache for strings of integers
See pull request Allocations optimization for converters quickfix-j#34
See pull request Allocations optimization for converters quickfix-j#34
See pull request Allocations optimization for converters quickfix-j#34
See pull request Allocations optimization for converters quickfix-j#34
Improve the way data attribute is cached (reuse the data field in toString(...) method. Use thread local buffer to generate the data attribute.
Use the Boolean converter to convert the value to a string
Use the DoubleConverter to convert value to a string. Avoid creation of a Double instance when using a scalar double.
Use the UtcDateOnlyConverter converter to convert value to a string
Use the UtcTimeOnlyConverter converter to convert value to a string
Use the UtcTimestampConverter converter to convert value to a string
Avoid string allocation when storing next target / sender sequence number
Double value improperly converted to string
fixed a regression on double conversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made use of converters in some fields to convert value to a string, this way it avoid some allocations.
Optimize the DoubleField class to efficiently manage 'double' by not mandatory converting them to 'Double'.