Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added sonarLint to the table and updated the RSLint Rules link #355

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Xanas1252
Copy link
Contributor

@Xanas1252 Xanas1252 commented Jun 11, 2021

updated the RSLint Rules link since the current one returns 404 page (done in a new PR)

  • added SonarLint to the table except the speed and LSP server

@github-actions
Copy link

github-actions bot commented Jun 11, 2021

CLA Assistant Lite bot Thank you for your contribution! Like many free software projects, you must sign our Contributor License Agreement before we can accept your contribution.

EDIT: All contributors have signed quick-lint-js' Contributor License Agreement (CLA-v1.md).

Copy link
Contributor Author

@Xanas1252 Xanas1252 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have read and hereby agree to quick-lint-js' Contributor License Agreement (CLA-v1.md).

Comment on lines 370 to 379
href="https://rdambrosio016.github.io/RSLint/rules/index.html"
href="https://rslint.org/rules/"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this into a separate commit or PR.

@@ -245,6 +246,8 @@ <h2 id="linter-feature-comparison">Features</h2>
<td class="meh">open source<br />MIT</td>
<td class="meh">open source<br />MIT</td>
<td class="meh">open source<br />MIT</td>
<td class="meh">LGPL</td>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be "good" and should mention "free", like quick-lint-js' cell.

@@ -475,6 +496,7 @@ <h2 id="linter-feature-comparison">Features</h2>
<td class="bad"><span aria-label="no">❌</span></td>
<td class="bad"><span aria-label="no">❌</span></td>
<td class="bad"><span aria-label="no">❌</span></td>
<td class="bad"><span aria-label="no">❌</span></td>
</tr>
<tr>
<th colspan="2">LSP server</th>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking: Add missing cell for LSP server.

It looks like their VS Code plugin uses an LSP server, so I'd say ✅ for SonarLint+LSP.

@@ -245,6 +246,8 @@ <h2 id="linter-feature-comparison">Features</h2>
<td class="meh">open source<br />MIT</td>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking: Add a cell for SonarLint for the speed column. Write "?" if you're unsure about the speed; we can fill it in later after we run benchmarks.

@@ -207,6 +207,7 @@ <h2 id="linter-feature-comparison">Features</h2>
<th><a href="https://rslint.org/">RSLint</a></th>
<th><a href="https://deno.land/">Deno</a></th>
<th><a href="https://rome.tools/">Rome</a></th>
<th><a href="https://sonarlint.org/">SonarLint</a></th>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table looks really wide. We could use &shy; to hyphenate "SonarLint" as "Sonar-Lint" to reduce the table width:

Suggested change
<th><a href="https://sonarlint.org/">SonarLint</a></th>
<th><a href="https://sonarlint.org/">Sonar&shy;Lint</a></th>

@@ -432,6 +452,7 @@ <h2 id="linter-feature-comparison">Features</h2>
<td class="bad"><span aria-label="no">❌</span></td>
<td class="good"><span aria-label="yes">✅</span></td>
<td class="bad"><span aria-label="no">❌</span></td>
<td class="bad"><span aria-label="no">❌</span></td>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking: SonarLint's website claims it has an IntelliJ (aka WebStorm) plugin. Does it not work for JS code? https://www.sonarlint.org/intellij/

@strager
Copy link
Collaborator

strager commented Jun 12, 2021

Regarding the CLA:

It looks like GitHub's API isn't returning your comment at all:

$ curl \
  -H "Accept: application/vnd.github.v3+json" \
  https://api.github.com/repos/quick-lint/quick-lint-js/pulls/355/comments | jq 'map(.body)'
[
  "Move this into a separate commit or PR.",
  "This should be \"good\" and should mention \"free\", like quick-lint-js' cell.",
  "Blocking: Add missing cell for LSP server.\r\n\r\nIt looks like their VS Code plugin uses an LSP server, so I'd say ✅ for SonarLint+LSP.",
  "Blocking: Add a cell for SonarLint for the speed column. Write \"?\" if you're unsure about the speed; we can fill it in later after we run benchmarks.",
  "The table looks really wide. We could use `&shy;` to hyphenate \"SonarLint\" as \"Sonar-Lint\" to reduce the table width:\r\n```suggestion\r\n              <th><a href=\"https://sonarlint.org/\">Sonar&shy;Lint</a></th>\r\n```",
  "Blocking: SonarLint's website claims it has an IntelliJ (aka WebStorm) plugin. Does it not work for JS code? https://www.sonarlint.org/intellij/"
]

$ curl \
  -H "Accept: application/vnd.github.v3+json" \
  https://api.github.com/repos/quick-lint/quick-lint-js/issues/355/comments | jq 'map(.body)'
[
  "**CLA Assistant Lite bot:** Thank you for your contribution! Like many free software projects, you must sign our [Contributor License Agreement](https://github.com/quick-lint/quick-lint-js/blob/master/docs/CLA-v1.md) before we can accept your contribution. You can agree to the Contributor License Agreement by copy-pasting the following message into a new comment on this GitHub pull request:\n   - - -\n   ***I have read and hereby agree to quick-lint-js' Contributor License Agreement (CLA-v1.md).***\n   - - -\n   <sub>You can retrigger this bot by commenting **recheck** in this Pull Request</sub>"
]

Maybe this is why the CLA bot isn't detecting your comment.

@Xanas1252 Can you try reposting the CLA acceptance message in a new comment?

@Xanas1252
Copy link
Contributor Author

Xanas1252 commented Jun 13, 2021

I have read and hereby agree to quick-lint-js' Contributor License Agreement (CLA-v1.md)

@Xanas1252 Xanas1252 changed the title added sonarLint to the table and updated the RSLint Rules link added sonarLint to the table ~~and updated the RSLint Rules link~~ Jun 15, 2021
@Xanas1252 Xanas1252 changed the title added sonarLint to the table ~~and updated the RSLint Rules link~~ added sonarLint to the table and updated the RSLint Rules link Jun 15, 2021
@strager strager linked an issue Sep 23, 2021 that may be closed by this pull request
2 tasks
@strager
Copy link
Collaborator

strager commented Dec 2, 2021

@Xanas1252 do you plan to update this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compare with SonarLint
2 participants