-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added sonarLint to the table and updated the RSLint Rules link #355
base: master
Are you sure you want to change the base?
Conversation
CLA Assistant Lite bot Thank you for your contribution! Like many free software projects, you must sign our Contributor License Agreement before we can accept your contribution. EDIT: All contributors have signed quick-lint-js' Contributor License Agreement (CLA-v1.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have read and hereby agree to quick-lint-js' Contributor License Agreement (CLA-v1.md).
website/public/index.ejs.html
Outdated
href="https://rdambrosio016.github.io/RSLint/rules/index.html" | ||
href="https://rslint.org/rules/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this into a separate commit or PR.
website/public/index.ejs.html
Outdated
@@ -245,6 +246,8 @@ <h2 id="linter-feature-comparison">Features</h2> | |||
<td class="meh">open source<br />MIT</td> | |||
<td class="meh">open source<br />MIT</td> | |||
<td class="meh">open source<br />MIT</td> | |||
<td class="meh">LGPL</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be "good" and should mention "free", like quick-lint-js' cell.
@@ -475,6 +496,7 @@ <h2 id="linter-feature-comparison">Features</h2> | |||
<td class="bad"><span aria-label="no">❌</span></td> | |||
<td class="bad"><span aria-label="no">❌</span></td> | |||
<td class="bad"><span aria-label="no">❌</span></td> | |||
<td class="bad"><span aria-label="no">❌</span></td> | |||
</tr> | |||
<tr> | |||
<th colspan="2">LSP server</th> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking: Add missing cell for LSP server.
It looks like their VS Code plugin uses an LSP server, so I'd say ✅ for SonarLint+LSP.
@@ -245,6 +246,8 @@ <h2 id="linter-feature-comparison">Features</h2> | |||
<td class="meh">open source<br />MIT</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking: Add a cell for SonarLint for the speed column. Write "?" if you're unsure about the speed; we can fill it in later after we run benchmarks.
@@ -207,6 +207,7 @@ <h2 id="linter-feature-comparison">Features</h2> | |||
<th><a href="https://rslint.org/">RSLint</a></th> | |||
<th><a href="https://deno.land/">Deno</a></th> | |||
<th><a href="https://rome.tools/">Rome</a></th> | |||
<th><a href="https://sonarlint.org/">SonarLint</a></th> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The table looks really wide. We could use ­
to hyphenate "SonarLint" as "Sonar-Lint" to reduce the table width:
<th><a href="https://sonarlint.org/">SonarLint</a></th> | |
<th><a href="https://sonarlint.org/">Sonar­Lint</a></th> |
@@ -432,6 +452,7 @@ <h2 id="linter-feature-comparison">Features</h2> | |||
<td class="bad"><span aria-label="no">❌</span></td> | |||
<td class="good"><span aria-label="yes">✅</span></td> | |||
<td class="bad"><span aria-label="no">❌</span></td> | |||
<td class="bad"><span aria-label="no">❌</span></td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking: SonarLint's website claims it has an IntelliJ (aka WebStorm) plugin. Does it not work for JS code? https://www.sonarlint.org/intellij/
Regarding the CLA: It looks like GitHub's API isn't returning your comment at all:
Maybe this is why the CLA bot isn't detecting your comment. @Xanas1252 Can you try reposting the CLA acceptance message in a new comment? |
I have read and hereby agree to quick-lint-js' Contributor License Agreement (CLA-v1.md) |
@Xanas1252 do you plan to update this PR? |
updated the RSLint Rules link since the current one returns 404 page(done in a new PR)