Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detail not working with Abstract Vectors, only with DataFrame. #346

Open
davibarreira opened this issue Dec 10, 2020 · 1 comment
Open

Comments

@davibarreira
Copy link

For a 100x4 array containing my data, if I try to plot the following:

@vlplot(:line,x=df[:,1],y=df[:,2],color={df[:,3],type="q"},order ={field ="row", type="q"},detail={df[:,4],type="o"})

I get the following Warning:
WARN Dropping {"type":"o"} from channel "detail" since it does not contain any data field, datum, value, or signal.

And the "detail" is not applied. Note that even if I add the name "field", thus making

@vlplot(:line,x=df[:,1],y=df[:,2],color={df[:,3],type="q"},order ={field ="row", type="q"},detail={field=df[:,4],type="o"})

Then I don't get any warnings, but the "detail" is not added.
If instead I use a DataFrame:

@vlplot(data=df,:line,x=:x,y=:y,color={:z,type="q"},order ={field =:row, type=:q },detail={field="group",type="o"})

Then everything works properly.

@davidanthoff
Copy link
Member

So the reason this doesn't work is that I disabled it in 2e2dfce. I labeled that commit as "fixing some bug", but I don't remember what the bug was... But given that I explicitly fixed something there, I'm a bit nervous about undoing it again... Not sure what to think of this right now... Maybe one of the other contributors here has an idea why I might have done this in the past? And yes, I know what a ridiculous question that is ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants