Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: rpm: consult dnf database for repository information #869

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

hdonnay
Copy link
Member

@hdonnay hdonnay commented Mar 13, 2023

tk

See-also: #809

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: Patch coverage is 29.52381% with 74 lines in your changes missing coverage. Please review.

Project coverage is 55.23%. Comparing base (c2fc225) to head (57bb054).

Files Patch % Lines
rpm/dnf.go 25.71% 52 Missing ⚠️
rpm/packagescanner.go 14.28% 18 Missing ⚠️
rhel/coalescer.go 57.14% 1 Missing and 2 partials ⚠️
rpm/native_db.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #869      +/-   ##
==========================================
- Coverage   55.39%   55.23%   -0.17%     
==========================================
  Files         282      283       +1     
  Lines       17836    17923      +87     
==========================================
+ Hits         9881     9899      +18     
- Misses       6923     6990      +67     
- Partials     1032     1034       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This change consults the dnf history database for the repository a package came
from, unless the layer has some features that we know means the results will be
useless.

See-also: quay#809
Signed-off-by: Hank Donnay <[email protected]>
This makes things easier to reason about and removes the ad-hoc parsing
that used to happen.

Signed-off-by: Hank Donnay <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant